Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting jvm-1.8 for plugin jar #123

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Targeting jvm-1.8 for plugin jar #123

merged 1 commit into from
Jan 12, 2024

Conversation

gmazzo
Copy link
Owner

@gmazzo gmazzo commented Jan 12, 2024

Works-around #120 by targeting Java 1.8 when compiling the plugin.

Note

This does not make the plugin compatible with Java 8, specifically when using Map build config fields, as the default implementation will be still be using Map.of only available since Java 9

@gmazzo gmazzo enabled auto-merge (rebase) January 12, 2024 14:30
@gmazzo gmazzo disabled auto-merge January 12, 2024 14:32
@gmazzo gmazzo enabled auto-merge (rebase) January 12, 2024 14:34
@gmazzo gmazzo merged commit 7017e60 into main Jan 12, 2024
3 checks passed
@gmazzo gmazzo deleted the target-jdk8 branch January 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant