You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for the effort! You are however not the first one to suggest this.
The thing is, handlebars-xgettext should work pretty much exactly like xgettext (used for other languages, like JavaScript).
(Maybe one day, xgettext can even parse Handlebars and handlebars-xgettext becomes obsolete.)
This means string replacement is not something handlebars-xgettext should know about.
Some background
Handlebars' philosophy is: templates should be simple. Because of this, there is no way to wrap helpers (handlebars 1.3.0 now supports subexpressions). This leads many people to a solution like yours, where you do multiple things in one fat helper (string replacement and translation).
The better way however, is to pass the end-result to your template:
handlebarsTemplate({hello: stringReplacement(gettext('Hello %s, it is %s'),name,weekDay)});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the user to pass arguments to the translate method that can get placed into the string, like this:
The parser will match the string and ignore the options.