Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Add script to deploy into a single node minikube instance #486

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

ansiwen
Copy link
Contributor

@ansiwen ansiwen commented Jun 14, 2018

This script takes an existing minikube instance in which it creates a
block device image under mnt/vda1/heketi-bricks.img that is connected
to /dev/loop1. Then gk-deploy is started in the single-node mode on
top of minikube and a default storage class gluster-storage is
created.

This change is Reviewable

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea! Though please add an option to control the size of the bricks file.

I also don't know much about minikube, what is the ISO you're downloading?

@ansiwen ansiwen force-pushed the deploy-minikube branch 2 times, most recently from ef8d151 to 7d45d07 Compare June 18, 2018 13:07
@ansiwen
Copy link
Contributor Author

ansiwen commented Jun 18, 2018

@jarrpa: I'm nor sure it makes sense to make the size of the bricks file configurable. It is a sparse file of 10GB and sits inside an image of an hard-coded size of 13GB, that is created by minikube. I can't think of a scenario where it is useful to make it smaller or bigger. Do you have one?

Creating the ISO was actually the biggest effort for this PR. 😅 I added some background on it in the commit notes and how to create it by yourself.

@jarrpa
Copy link
Contributor

jarrpa commented Jun 26, 2018

....ah, okay! In that case could you just provide hints on how to create the minikube image as comments in the script? I can almost guarantee that people won't think to look in the commit notes.

@ansiwen
Copy link
Contributor Author

ansiwen commented Jul 24, 2018

@jarrpa I pushed a new version which only deploys on an existing minikube deployment, since the latest version of minikube includes the heketi/gluster dependencies now in the latest release, after this had been merged: kubernetes/minikube#2925

This script takes an existing minikube instance in which it creates a
block device image under mnt/vda1/heketi-bricks.img that is connected
to /dev/loop1.  Then gk-deploy is started in the single-node mode on
top of minikube and a default storage class gluster-storage is
created.
Copy link
Contributor

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jarrpa jarrpa merged commit f8647ae into gluster:master Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants