Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Automatically create a dynamically provisioning StorageClass #484

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

patrickmslatteryvt
Copy link

@patrickmslatteryvt patrickmslatteryvt commented Jun 11, 2018

Add option to automatically create a dynamically provisioning StorageClass after the GlusterFS daemon-set deployment has completed.

To automatically create a StorageClass named: glusterfs-storage

./gk-deploy --yes --deploy-gluster --namespace glusterfs --create-dynamic-sc

To automatically create a StorageClass named: glusterfs-ssd-storage

./gk-deploy --yes --deploy-gluster --namespace glusterfs --create-dynamic-sc --dynamic-sc "glusterfs-ssd-storage"

I don't have access to an OpenShift cluster to test this against so I didn't include the template for OpenShift.


This change is Reviewable

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't think we need to bother having two flags. Just use one --storage-class flag, where it can be in one of three states:

  • Default value of "", no SC
  • If flag is specified but with no value, default value of glusterfs
  • If flag is specified with a value, use that as the SC name.

@patrickmslatteryvt
Copy link
Author

OK, sure. I can make those changes.

Copy link
Contributor

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close, but not quite. I want the default value at the top of the file to be "". If the option is specified, that value changes to "glusterfs", and if the option is specifies a value then that value is used as the StorageClass name.

@patrickmslatteryvt
Copy link
Author

OK, I messed up on the last one, I get what you mean now. I'll fix it in a day or two, I need to make another test cluster to validate it on first...

Also I was thinking I could add an option to set the StorageClass as default, your thoughts?

@jarrpa
Copy link
Contributor

jarrpa commented Jun 14, 2018

Couldn't hurt to add it. --storage-class-default or something like that.

@ansiwen
Copy link
Contributor

ansiwen commented Jun 19, 2018

How about a --storage-class-volumetype option as well? For minikube I would need volumetype: "none", and it would be nice to use this new feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants