More dummy AWT methods #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanvos
approved these changes
Jul 29, 2021
makingthematrix
added a commit
to makingthematrix/substrate
that referenced
this pull request
Sep 8, 2021
This is a follow up to gluonhq#971 and gluonhq#972. I made a minimal Android app with FXGL, the game engine which uses JavaFX. It turns out that GraalVM Native Image adds many more unresolved references when compiling FXGL. I added the dummy methods for them to launcher.c. With these changes my minimal app works but I wonder if this is a good approach. All the methods I added have something to do with image handling. What if, when I start to write a more complex app, GraalVM Native Image will start adding even more references? Here's my app: https://github.com/makingthematrix/scalaonandroid/tree/main/HelloFXGL
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #970
Progress