Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Android OS handle volume events #1209

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

jperedadnr
Copy link
Contributor

Issue

Fixes #1208

Progress

@salmonb
Copy link

salmonb commented Mar 5, 2023

I tested this PR along with my PR regarding the AndroidAudioService, and my tests confirm that this PR is fixing the issue with the volume buttons: now they are simply handled by Android, without the need to rewrite the code for the volume management in the service (calling activity.setVolumeControlStream() is enough to make the volume buttons work) 👍

@jperedadnr
Copy link
Contributor Author

Great, thanks for testing!

@jperedadnr jperedadnr merged commit 426bef5 into gluonhq:master Mar 6, 2023
@jperedadnr jperedadnr deleted the 1208-volume branch March 6, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] KeyEvents from volume buttons shouldn't be consumed
3 participants