Check GraalVM version before returning macos/darwin platform. #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperedadnr
reviewed
Feb 18, 2022
| boolean graalVM221 = false; | ||
| try { | ||
| Version graalVersion = projectConfiguration.getGraalVersion(); | ||
| if ((graalVersion.getMajor() > 21) && (graalVersion.getMinor() >0)) graalVM221 = true; |
There was a problem hiding this comment.
Remove if and assign graalVM221directly?
| Version graalVersion = projectConfiguration.getGraalVersion(); | ||
| if ((graalVersion.getMajor() > 21) && (graalVersion.getMinor() >0)) graalVM221 = true; | ||
| } catch (IOException ex) { | ||
| ex.printStackTrace(); |
There was a problem hiding this comment.
I don't think we need an stacktrace here?
There was a problem hiding this comment.
why not? This should never happen, so if it happens, we at least need a detailed reason (or we should call System.exit())
jperedadnr
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1121
Checks GraalVM version
Issue
Fixes #1121
Progress