-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check GraalVM version before returning macos/darwin platform. #1123
Conversation
boolean graalVM221 = false; | ||
try { | ||
Version graalVersion = projectConfiguration.getGraalVersion(); | ||
if ((graalVersion.getMajor() > 21) && (graalVersion.getMinor() >0)) graalVM221 = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove if
and assign graalVM221
directly?
Version graalVersion = projectConfiguration.getGraalVersion(); | ||
if ((graalVersion.getMajor() > 21) && (graalVersion.getMinor() >0)) graalVM221 = true; | ||
} catch (IOException ex) { | ||
ex.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need an stacktrace here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? This should never happen, so if it happens, we at least need a detailed reason (or we should call System.exit())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Windows failure related to #1111)
This closes #1121
Checks GraalVM version
Issue
Fixes #1121
Progress