fix: Remove platform theme url from stylesheets, #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m being overwritten
johanvos
approved these changes
Oct 21, 2024
jperedadnr
changed the title
erwin1
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent user agent from being overwritten
This PR removes the platform stylesheet from the theme in content/preview, which is modena.css, since it is already added to Scene Builder, preventing the user agent stylesheets from external controls in the custom library to be overwritten.
This was only working before #745 and #720 by an underlying bug (modena.bss was used to create an invalid URL and the real modena.css URL was never added to the theme stylesheets.
Issue
Fixes #760
Progress