Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower required Java level to 21 #722

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Lower required Java level to 21 #722

merged 2 commits into from
Sep 27, 2024

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Sep 26, 2024

Issue

Fixes #721

Progress

abhinayagarwal
abhinayagarwal previously approved these changes Sep 27, 2024
johanvos
johanvos previously approved these changes Sep 27, 2024
Copy link
Contributor

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to replace the commit message to "lower required Java level to 21"
(avoiding worries from people who think that they can't use Java 23)

@Oliver-Loeffler
Copy link
Collaborator

Might be good to replace the commit message to "lower required Java level to 21" (avoiding worries from people who think that they can't use Java 23)

We can make a statement about this setup in README.md Requisites Section. @jperedadnr Could you please add this change? When adding this, could you please attempt to rephrase the commit message?

Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update README.md Requisites Section accordingly?

@jperedadnr jperedadnr changed the title Lower Java level to 21 Lower required Java level to 21 Sep 27, 2024
@jperedadnr
Copy link
Collaborator Author

I've updated the readme, that now says Java 21 or later, so that is good enough I guess.

@jperedadnr
Copy link
Collaborator Author

The commit message will take the PR's title once squashed and merged

@Oliver-Loeffler Oliver-Loeffler merged commit b6e0f15 into master Sep 27, 2024
3 checks passed
@jperedadnr jperedadnr deleted the jperedadnr-patch-1 branch September 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java language level for Scene Builder Kit
4 participants