fix: colorpicker move on input #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
Signed-off-by: leewyatt <[email protected]>
…uts: The area was previously shifting due to ScrollPane default behaviors.
abhinayagarwal
changed the title
jperedadnr
reviewed
Mar 11, 2024
|
@jperedadnr Thank you for reviewing my pull request and for your valuable feedback. I've updated the code according to your suggestions. Please let me know if there are any further adjustments needed. |
jperedadnr
reviewed
Mar 12, 2024
...ava/com/oracle/javafx/scenebuilder/kit/util/control/paintpicker/colorpicker/ColorPicker.java
Outdated
Show resolved
Hide resolved
…rol/paintpicker/colorpicker/ColorPicker.java Co-authored-by: José Pereda <[email protected]>
|
Thank you for the suggestion! I've committed the changes as per your review. |
|
Oh, one more little change is required before we can merge this PR, we need to update the copyright year of the modified file. Please change: into: |
|
ok, changed~ |
jperedadnr
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR addresses the unexpected movement of the ColorPicker area when it gains focus and certain mouse or keyboard inputs are made.
Issue
Fixes #654
Progress