fix: Scene Builder now shows a message which FXML imports were not resolvable #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unresolved imports. There is also a new option (preserve unresolved imports) which also allows to keep the imports in saved FXML files.
…d and how this could be avoided. This is only active when the preference `keep unresolved imports` is set true.
…of FXML with unresolved imports' as it exactly does the 2nd.
4 tasks
Oliver-Loeffler
changed the title
4 tasks
|
This one is no longer needed as the related change is now part of #576 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Up to now, Scene Builder did not load FXML files with unresolvable imports. This is basically enabled by PR #576.
This PR enables Scene Builder to provide a list of failing imports to the user, together with an instruction on how to include the missing classes/JAR files in Scene Builder.
The
EditorDialogincom.oracle.javafx.scenebuilder.kit.editor.panel.util.dialoghas been updated so that its Detail window has also the correct application icon and window title. The main EditorDialog also now has the correct application icon.Fixes #281 but requires PR #576 first
Progress