-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure rolling releases #458
Conversation
Converting to draft as JReleaser |
Many thanks for this. I've skimmed through to get a rough idea and left some questions, but I don't have the required SB build / release expertise, so I'm tagging @jperedadnr and @abhinayagarwal Once this is ready and merged, we should have a much quicker response iteration between the dev team and the users. |
I did an initial overview of the PR. Overall, its great work. Thank you @aalmiray for taking the time. Here are my initial thoughts & questions on the PR:
|
Homebrew can be added easily however be aware that this is via a tap repository under your control and not a core formula. Other packagers such as Snap, Chocolatey, etc are not yet supported. That's something I can have a look at.
Only if they download artifacts from the GH workflow download area which is not ideal, that's one of the reasons for crafting early access releases, which answers the next question
JReleaser tags, creates a Git release with changelog, uploads all artifacts as release assets alongside their checksums.
Right. TAG is akin to the project version while VERSION is akin to the app version used by jpackage. Right now both the project version and the git tag match while the app version differs as it can't contain elements such as -RC or -SNAPSHOT. |
Force pushed the following changes:
Note that a new secret named |
PR is ready for review. Package managers such as Homebrew, Macports, Chocolatey, Snap have been disabled as they require additional setup such as service accounts and API keys. We can discuss which package managers should be enabled and their requirements. For the time being this PR will enable rolling releases on every push to the |
That's correct difference b/w TAG and VERSION. My initial concern was in case of early-access, we still use TAG, which is coming from previous workflows. However, since there is no tag involved, we may want to rename it to |
OK but be aware that changes to the jpackage scripts are also required as they expect |
I'd recommend squashing commits when merging this PR. |
Yes, squash and merge is the default option for this repo. |
Hi @aalmiray , As suggested, I tried adding
P.S. We generally use |
Oops you are right. I used |
@gluon-bot's PAT added as a secret |
Looks like early-access.yml#L99 must be deleted. I missed it. The bundle-kit.yml workflow does not have an "app-version" input. |
Issue
Configures rolling releases on every push to
master
branch.Configures final release on workflow dispatch (manual trigger)
Rolling releases publish binaries only as Git release assets.
Final release additionally publishes binaries to S3.
Fixes #446
Progress