Switch back to mainline swift-markdown-ui #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingorichter
added a commit
to ingorichter/enchanted
that referenced
this pull request
Oct 29, 2024
|
Hi @gluonfield, I am puzzled by this PR not being merged or rejected. I was not able to build the project in the current Xcode without doing something about the circular reference in markdown-ui. So I forked your repo and cherry-picked bolot's commit. Maybe there is another solution you would prefer to his approach? Whatever the case, it would be nice to hear from you. I like the project and admire the hard work and dedication you put into it. It would be fun to casually contribute and the PR you already received indicate that I am not the only one seeing it that way. But this begs the question whether you actually want that and have the energy and motivation to continue the project. |
olegshulyakov
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project currently does not build on Xcode 16, due to the issue in https://github.com/AugustDev/swift-markdown-ui. This was reported as an issue on this project:
The upstream repo https://github.com/gonzalezreal/swift-markdown-ui includes the fix to the Xcode 16 build issue:
This PR fixes the project by switching over to the upstream
swift-markdown-uidependency.