Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProgressParams #43

Closed
wants to merge 1 commit into from
Closed

Conversation

algesten
Copy link

@algesten algesten commented Jan 7, 2018

This PR is in flux and shouldn't land before the proposed changes to LS spec.

microsoft/vscode-languageserver-node#261

Fixed feedback in #42

@Xanewok
Copy link
Collaborator

Xanewok commented Apr 12, 2019

Thankfully, microsoft/vscode-languageserver-node#261 has been merged now 🎉
Would it be possible to rebase this and adapt (e.g. title is non-optional) to the changes?

@Marwes how should we proceed with proposed LSP features? Should we typedef this as usual?

@Marwes
Copy link
Member

Marwes commented Apr 12, 2019

how should we proceed with proposed LSP features? Should we typedef this as usual?

What do you mean with typedef?

@Marwes
Copy link
Member

Marwes commented Apr 12, 2019

how should we proceed with proposed LSP features?

I am thinking we may want to merge proposed features but put them under a "propesed"/"unstable" feature for which we make no semver promises for (users will need to use = when depending on this crate)

@Xanewok
Copy link
Collaborator

Xanewok commented Apr 12, 2019

Makes sense! @algesten could you update this PR or should I?

What do you mean with typedef?

Sorry, took a mental shortcut - I meant just write type definitions for the LSP types/interfaces as usual

@algesten
Copy link
Author

Sorry. I was not monitoring my email there. Seems you solved it! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants