Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for connect_list_selection and fix remaining PyQt6 issue #35

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

astrofrog
Copy link
Member

Somehow I had not added a test for connect_list_selection - this also fixes a PyQt6 issue from code now covered by new test

@astrofrog astrofrog added the bug label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 94.28% // Head: 96.65% // Increases project coverage by +2.37% 🎉

Coverage data is based on head (46139f2) compared to base (cf80544).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   94.28%   96.65%   +2.37%     
==========================================
  Files          16       17       +1     
  Lines        2098     2182      +84     
==========================================
+ Hits         1978     2109     +131     
+ Misses        120       73      -47     
Impacted Files Coverage Δ
echo/qt/connect.py 88.78% <100.00%> (+15.06%) ⬆️
echo/qt/tests/test_connect_list_selection.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@astrofrog astrofrog merged commit ab38456 into glue-viz:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant