ILRepack doesn't work with default parameter values... well.. now it does...#1
Merged
Conversation
gluck
added a commit
that referenced
this pull request
May 22, 2012
ILRepack doesn't work with default parameter values... well.. now it does...
Owner
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when ILRepack is run against an assembly with default params, the default param flags are copied, but the default constant is NOT...
so when a method like:
was processed, the resulting assembly would crash on mono and not compile on ms .NET since the constant was missing from the method definition...
this 2 line change in the MethodDefinition clone method fixes this...