Skip to content

Conversation

@archmoj
Copy link
Contributor

@archmoj archmoj commented Nov 20, 2020

@archmoj archmoj requested a review from rreusser November 24, 2020 14:00
@rreusser
Copy link
Member

As this is a compile-time dependency of glslify, nothing jumps out as problematic. You can find the events release notes here. Lack of IE8 support for bundling should be… acceptable, I think. As long as tests pass, seems fine to me. 👍

@archmoj
Copy link
Contributor Author

archmoj commented Nov 25, 2020

As this is a compile-time dependency of glslify, nothing jumps out as problematic. You can find the events release notes here. Lack of IE8 support for bundling should be… acceptable, I think. As long as tests pass, seems fine to me. 👍

Are you going to release a major or patch please?

@rreusser
Copy link
Member

As this doesn't affect usage of glslify-deps, I think this seems like it ought to be a patch version. 1.3.2, I think. Releasing…

Copy link
Member

@rreusser rreusser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the tests, and appears good to me. Since this doesn't affect usage of glslify-deps, I believe, will follow with a patch increment.

@rreusser rreusser merged commit ef99f3f into glslify:master Nov 25, 2020
@archmoj archmoj deleted the bump-events-in-glslify branch November 25, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants