Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance image checks #5580

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Enhance image checks #5580

merged 1 commit into from
Mar 12, 2019

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Mar 12, 2019

Use exif if present to check if file is image, or fallback with W on fileinfo

Q A
Bug fix? yes/no
New feature? yes/no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #number

@trasher trasher added this to the 9.4.1 milestone Mar 12, 2019
@trasher trasher requested review from orthagh and cedric-anne March 12, 2019 13:50
cedric-anne
cedric-anne reviewed Mar 12, 2019
View reviewed changes
inc/document.class.php Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@cedric-anne cedric-anne mentioned this pull request Mar 12, 2019
Merged
@trasher trasher force-pushed the check-images branch 2 times, most recently from 560be65 to dcbb743 Compare March 12, 2019 15:02
@trasher trasher merged commit 0fced6d into glpi-project:9.4/bugfixes Mar 12, 2019
@trasher trasher deleted the check-images branch March 12, 2019 15:17
@trasher trasher mentioned this pull request Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh orthagh approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees
No one assigned
Labels
bug security
Projects
None yet
Milestone
9.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@trasher @orthagh @cedric-anne