Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache the results of
chunk_exists
calls from frame 0.Motivation and Context
This increases performance. In cases where users write many values that match defaults, the previous code would check (for every single chunk) whether that chunk is present in frame 0:
The
chunk_exists
call triggers an implicit flush which decreases write performance significantly.After this change, the chunk_exists call is made once for frame 0 and the results are reused, resulting in no extra
chunk_exists
calls:How Has This Been Tested?
Existing tests pass.
hoomd-benchmarks.py
does not trigger the extrachunk_exists
calls, so it does not show any performance improvement. Use-cases that trigger it excessively should see improvement.Checklist:
doc/credits.rst
) in the pull request source branch.CHANGELOG.rst
.