Skip to content

Fix broken CI jobs on pybind11 branch. #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tommy-waltmann merged 23 commits into from
Jun 25, 2024
Merged

Fix broken CI jobs on pybind11 branch. #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f433c6d
Add nanobind to pyproject.toml.
joaander Jun 24, 2024
1d518d0
Attempt to run style check action.
joaander Jun 24, 2024
ea1102e
Use static_cast.
joaander Jun 24, 2024
77a495a
Add nanobind to unit test environment.
joaander Jun 24, 2024
423f497
Convert readthedocs build to pip.
joaander Jun 24, 2024
b48ac3e
Use reinterpret_cast
joaander Jun 24, 2024
bf82c81
Force usage of clang-tidy-10
joaander Jun 24, 2024
53602d1
Fix pre-commit failures.
joaander Jun 24, 2024
b44209e
Test only converted modules.
joaander Jun 24, 2024
9e85065
Show cppcheck and clang-tidy output.
joaander Jun 24, 2024
2c0c79e
Test only active modules in cibuildwheel.
joaander Jun 24, 2024
2044415
Make INSTALL_RPATH_USE_LINK_PATH global for cibuildwheel.
joaander Jun 24, 2024
3439088
Remove unused LD_LIBRARY_PATH.
joaander Jun 24, 2024
9ae18f2
Check the directory structure after install -e.
joaander Jun 24, 2024
8a0abea
Bring back deprecated setup.py usage.
joaander Jun 24, 2024
19efa4c
Install a matching version of cppcheck.
joaander Jun 24, 2024
1aca1d3
Fix some clang-tidy warnings.
joaander Jun 24, 2024
dd7ddeb
Fix compile errors.
joaander Jun 24, 2024
f584ade
Fix more clang-tidy errors.
joaander Jun 24, 2024
a5e0e9a
Do not fail fast.
joaander Jun 24, 2024
5751c6d
Use NB_STATIC on windows.
joaander Jun 24, 2024
6f6a408
Attempt to fix assert.
joaander Jun 24, 2024
4b44cf4
clang-tidy knows that assert is used only in debug mode.
joaander Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ jobs:
CIBW_ARCHS: auto64

# Configure environment variables.
CIBW_ENVIRONMENT_LINUX: "CMAKE_PREFIX_PATH=/project/tbb LD_LIBRARY_PATH=/project/tbb/lib/intel64/gcc4.8:$LD_LIBRARY_PATH"
CIBW_ENVIRONMENT_MACOS: "CMAKE_PREFIX_PATH=/Users/runner/work/freud/freud/tbb:/Users/runner/work/tbb-install LD_LIBRARY_PATH=/Users/runner/work/freud/freud/tbb/lib/intel64/gcc4.8:$LD_LIBRARY_PATH"
CIBW_ENVIRONMENT_LINUX: "CMAKE_PREFIX_PATH=/project/tbb LD_LIBRARY_PATH=/project/tbb/lib/intel64/gcc4.8:$LD_LIBRARY_PATH CMAKE_ARGS=-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=True"
CIBW_ENVIRONMENT_MACOS: "CMAKE_PREFIX_PATH=/Users/runner/work/freud/freud/tbb:/Users/runner/work/tbb-install CMAKE_ARGS=-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=True"
MACOSX_DEPLOYMENT_TARGET: "10.14"

# Set up TBB.
Expand All @@ -113,7 +113,9 @@ jobs:
scipy==${{ matrix.python.oldest_scipy }}
gsd==${{ matrix.python.oldest_gsd }}
matplotlib==${{ matrix.python.oldest_matplotlib }}
CIBW_TEST_COMMAND: "cd {package}/tests && pytest . -v --log-level=DEBUG"
# Test only the currently ported modules
CIBW_TEST_COMMAND: "cd {package}/tests && pytest test_box_Box.py test_parallel.py -v --log-level=DEBUG"
# CIBW_TEST_COMMAND: "cd {package}/tests && pytest . -v --log-level=DEBUG"

- uses: actions/upload-artifact@v4.3.3
with:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/env-files/environment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ channels:

dependencies:
- python==3.12
# TODO: Update to a newer cppcheck and adjust all C++ code to meet the new style guidlines
- cppcheck<2.0.0 # [linux64]
- tbb
- tbb-devel
- ninja
Expand All @@ -12,8 +14,10 @@ dependencies:
- dynasor
- gsd
- matplotlib
- nanobind>=2.0
- numpy
- pillow
- pre-commit
- pytest
- rowan
- scikit-build
Expand Down
Loading