Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove return type annotation on method externalKeyBindings #306

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Remove return type annotation on method externalKeyBindings #306

merged 1 commit into from
Mar 5, 2020

Conversation

brendonpagano
Copy link

Related Issue

None

Proposed Changes

  • Remove TypeScript-only feature on a JavaScript file

@mogavin mogavin requested review from mogavin and lousander and removed request for lousander March 2, 2020 21:07
mogavin
mogavin approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@mogavin mogavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @AnnaTsu !

@lousander lousander changed the base branch from master to new-release March 5, 2020 18:48
@lousander lousander changed the base branch from new-release to master March 5, 2020 18:50
@lousander lousander merged commit edb1893 into globocom:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogavin mogavin mogavin approved these changes

@lousander lousander lousander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendonpagano @mogavin @lousander