Data Integrity #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danieloni1
force-pushed
the
daniel/dev-1138-data-integrity
branch
11 times, most recently
from
177f16b to
218b000
Compare
danpe
requested changes
May 26, 2024
api/r0/upload_async.go
Outdated
| ) | ||
|
|
||
| func UploadMediaAsync(r *http.Request, rctx rcontext.RequestContext, user _apimeta.UserInfo) interface{} { | ||
| server := _routers.GetParam("server", r) | ||
| mediaId := _routers.GetParam("mediaId", r) | ||
| filename := filepath.Base(r.URL.Query().Get("filename")) | ||
| // GK-CUSTOMIZATION: Sanitize the filename | ||
| if len(filename) > 24 { |
There was a problem hiding this comment.
@Danieloni1 this should be set in the config.yaml under "Uploads"
util/mxc.go
Outdated
|
|
||
| // GK-CUSTOMIZATION: Supported file types | ||
| var supportedFileTypes = []string{ | ||
| "docx", |
There was a problem hiding this comment.
@Danieloni1 lets also move this to config yaml?
There's a nice example of having this kind of array at the thumbnails section
There was a problem hiding this comment.
Also, missing xls and mov types
Check my fully renewed list: https://www.notion.so/globekeeper/Supported-File-Types-403a4f05fb7e4f7c83954e52eac124f4?pvs=4#3f251b4a73be40a0a4dfe64b3d3571eb
Danieloni1
force-pushed
the
daniel/dev-1138-data-integrity
branch
from
216f1f9 to
10bb402
Compare
Danieloni1
force-pushed
the
daniel/dev-1138-data-integrity
branch
2 times, most recently
from
2670865 to
75237a7
Compare
Danieloni1
force-pushed
the
daniel/dev-1138-data-integrity
branch
from
75237a7 to
06337a5
Compare
|
👍 |
Danieloni1
force-pushed
the
daniel/dev-1138-data-integrity
branch
from
06337a5 to
aa4f010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.