Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin not working in latest flake8 version #35

Closed
guigarfr opened this issue Aug 1, 2022 · 6 comments
Closed

Plugin not working in latest flake8 version #35

guigarfr opened this issue Aug 1, 2022 · 6 comments

Comments

@guigarfr
Copy link

guigarfr commented Aug 1, 2022

flake8 has released a couple of version in the last days (5.0.0 and 5.0.1). When running flake8, it provides this error (fails with both flake8 versions):

pip install flake8==5.0.0
flake8 .
There was a critical error during execution of Flake8:
plugin code for `flake8-logging-format[logging-format]` does not match ^[A-Z]{1,3}[0-9]{0,3}$
@guigarfr
Copy link
Author

guigarfr commented Aug 1, 2022

Just saw there is a PR for it (#33) but there was not an open issue.

@cpina
Copy link

cpina commented Aug 1, 2022

Just found the same problem - thanks for reporting it @guigarfr

@christianbundy
Copy link

Looks like #33 was merged (thanks!), looking forward to upgrading once this is released to pypi.

dargor added a commit to dargor/dargor_gentoo_overlay that referenced this issue Aug 2, 2022
sebp added a commit to sebp/scikit-survival that referenced this issue Aug 2, 2022
flake8-logging-format plugin does not work with it.

See globality-corp/flake8-logging-format#35
Kyle-Verhoog added a commit to Kyle-Verhoog/dd-apm-test-agent that referenced this issue Aug 2, 2022
Kyle-Verhoog added a commit to DataDog/dd-apm-test-agent that referenced this issue Aug 2, 2022
@christianbundy
Copy link

@tonybajan-globality Anything we can do to help get this published to pypi?

sebp added a commit to sebp/scikit-survival that referenced this issue Aug 7, 2022
flake8-logging-format plugin does not work with it.

See globality-corp/flake8-logging-format#35
@guigarfr
Copy link
Author

guigarfr commented Aug 8, 2022

#42

@piercefreeman
Copy link
Contributor

Thanks for the contributions all. We've fixed the build pipeline and cut 0.7.4 to pypi, which should take care of this error. I've confirmed in another dependent repo that this issue looks fixed on flake8 5.x.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants