Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portalicious: refactor aggregates card AB#30918 #6061

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

arsforza
Copy link
Contributor

@arsforza arsforza commented Nov 8, 2024

AB#30918

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@arsforza arsforza added the portalicious Changes related to the portalicious release label Nov 8, 2024
Copy link
Member

@elwinschmitz elwinschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the small suggestion (and the rebase dance): LGTM(TM)

elwinschmitz
elwinschmitz previously approved these changes Nov 13, 2024
@elwinschmitz elwinschmitz enabled auto-merge (squash) November 13, 2024 09:13
@elwinschmitz elwinschmitz merged commit 8cedd03 into main Nov 13, 2024
5 checks passed
@elwinschmitz elwinschmitz deleted the arsforza/portalicious.refactor-card branch November 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portalicious Changes related to the portalicious release
Development

Successfully merging this pull request may close these issues.

2 participants