Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add send messages e2e test #6039

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Add send messages e2e test #6039

merged 4 commits into from
Nov 8, 2024

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Nov 6, 2024 •
edited
Loading

AB#31175

Describe your changes

Adds e2e tests for portalicious send message functionality

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Piotrk39 Piotrk39 added the chore Something that does not affect the end user label Nov 6, 2024
@Piotrk39 Piotrk39 changed the title Add send templated message e2e test Add send messages e2e test Nov 6, 2024
@Piotrk39 Piotrk39 added the portalicious Changes related to the portalicious release label Nov 6, 2024
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-tests-for-send-message branch from edc33f9 to aec7ddb Compare November 6, 2024 14:43
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-tests-for-send-message branch from 79d52ac to 4ec5f30 Compare November 7, 2024 08:23
@Piotrk39 Piotrk39 marked this pull request as ready for review November 7, 2024 08:54
aberonni
aberonni requested changes Nov 7, 2024
View reviewed changes
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/tests/SendMessage/SendCustomMessage.spec.ts Show resolved Hide resolved
e2e/portalicious/tests/SendMessage/SendTemplatedMessage.spec.ts Show resolved Hide resolved
@Piotrk39
Add send templated message e2e test
af7347d 
Add e2e tests for sending custom messages

Add missing file

Update toast message to validate action

change message validation

Change message to validate

Fix sorting add TableComponent
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-tests-for-send-message branch from c2a1c64 to af7347d Compare November 7, 2024 13:31
@aberonni aberonni self-requested a review November 7, 2024 13:34
aberonni
aberonni requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me if my remarks don't make sense ✌️

e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/TableComponent.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/TableComponent.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/TableComponent.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/TableComponent.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
aberonni
aberonni requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there!

e2e/portalicious/pages/RegistrationActivityLogPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationActivityLogPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationActivityLogPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/TableComponent.ts Show resolved Hide resolved
aberonni
aberonni previously approved these changes Nov 8, 2024
View reviewed changes
@Piotrk39 Piotrk39 enabled auto-merge (squash) November 8, 2024 09:51
@Piotrk39 Piotrk39 merged commit 83050f3 into main Nov 8, 2024
9 checks passed
@Piotrk39 Piotrk39 deleted the feat.add-e2e-tests-for-send-message branch November 8, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piotrk39 @aberonni