Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for User's last login #5973

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Add e2e test for User's last login #5973

merged 6 commits into from
Oct 25, 2024

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Oct 23, 2024 •
edited
Loading

AB#30874

Describe your changes

Adds test that asserts login time stamps in Users page

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Piotrk39 Piotrk39 added the enhancement New feature or request that affects our end users label Oct 23, 2024
@Piotrk39 Piotrk39 marked this pull request as ready for review October 23, 2024 13:35
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-users-last-login branch from ac6c397 to 92ae1e6 Compare October 23, 2024 13:35
@Piotrk39 Piotrk39 mentioned this pull request Oct 23, 2024
Closed
4 tasks
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-users-last-login branch from 9fb651a to f132fc8 Compare October 24, 2024 10:20
@Piotrk39
Copy link
Contributor Author

For the reviewer: PR also includes another test "View users page"

@aberonni aberonni self-requested a review October 25, 2024 11:46
aberonni
aberonni requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change but otherwise LGTM!

e2e/portalicious/pages/UsersPage.ts Outdated Show resolved Hide resolved
@Piotrk39 Piotrk39 enabled auto-merge (squash) October 25, 2024 12:10
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-users-last-login branch from 9b2bbe0 to cf0538a Compare October 25, 2024 12:10
@Piotrk39 Piotrk39 merged commit 284bd8c into main Oct 25, 2024
4 checks passed
@Piotrk39 Piotrk39 deleted the feat.add-e2e-test-for-users-last-login branch October 25, 2024 12:21
@aberonni aberonni added chore Something that does not affect the end user portalicious Changes related to the portalicious release and removed enhancement New feature or request that affects our end users labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piotrk39 @aberonni