Fix waitForWindow() on Mac and Windows. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid exception when getWindow() or getWindowTitle() is called while window isn't open yet and waiting for window. On Mac, return None instead of raising exception when PID window isn't found
glitchassassin
requested changes
Nov 13, 2018
lackey/App.py
Outdated
| return PlatformManager.getWindowTitle(PlatformManager.getWindowByPID(self.getPID())) | ||
| else: | ||
| return "" | ||
| return None |
There was a problem hiding this comment.
This should return an empty string, not None
| @@ -328,7 +328,7 @@ def getWindowRect(self, hwnd): | |||
| width = w["kCGWindowBounds"]["Width"] | |||
| height = w["kCGWindowBounds"]["Height"] | |||
| return (x, y, width, height) | |||
| raise OSError("Unrecognized window number {}".format(hwnd)) | |||
| return None | |||
There was a problem hiding this comment.
This particular method should raise a descriptive error. Returning None when the recipient is expecting a tuple will just raise a different (less clear) error.
glitchassassin
approved these changes
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid exception when getWindow() or getWindowTitle() is called while window isn't open yet and waiting for window.
On Mac, return None instead of raising exception when PID window isn't found