-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds @cached decorator #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
I think this needs to be implemented in Ember as well, since Ember has its own implementation of |
@pzuraq why is that? is it worth using this effort to make ember use this |
ah looks like there is computed interop in there 🤔 |
aa43532
to
ae4d881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding tests for using the decorator with private getters? Or is caching a private getter expected to never be supported?
Afaik, It's not possible with today's decorators because of how the transpiling happens. But it should work with the new decorators proposal, afaik. @pzuraq would have details. ;) |
looks like the errors here in CI are present on every other PR 🎉 |
Ember version: emberjs/ember.js#19772 |
427fe2a
to
62f6dc2
Compare
Since this has landed in ember, would it be possible to merge this as well? As of now, e.g. when using Typescript it is a bit akward, since |
Ya, we should definitely get this landed. @NullVoxPopuli - Can you rebase to kick off a new set of tests? |
it's already up to date / fully rebased |
@rwjblue any way you/we/i can click the "re-run all jobs button"? |
Hmm, no? There is no "re-run all" button on the checks tab. |
72a33e8
to
781b7e9
Compare
🎉 |
This is the same implementation as ember and the polyfill