This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure stability of destroyable APIs in Ember 3.22+.
In Ember 3.20 and 3.21 the official `isDestroying` and `isDestroyable` APIs were not published so we reached into the `@glimmer/runtime` internals. In the meantime, the actual location of the destroyable implementation has changed from `@glimmer/runtime` to `@glimmer/destroyable` (on Ember 3.25's canary cycle). This has lead to a number of failures for folks that are testing against those canary builds. This commit changes the implementation to use Ember's own official public API location for `isDestroying`/`isDestroyed` when using Ember 3.22+ (which nicely absorbs the issue for 3.25 canary users, and guarantees some additional level of stability).
- Loading branch information
Showing
3 changed files
with
24 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters