Make consumable from Ember without npm link.
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we do not have to run bower install in the nested glimmer-engine dep from Ember itself.
This allows the build to succeed even if bower_components is missing. This is important when running the ember-cli-build.js file from within another project (which includes its own QUnit and loader).
|
|
||
|
|
||
| var tokenizerPath = path.join(require.resolve('simple-html-tokenizer'), '..', '..', 'lib'); |
There was a problem hiding this comment.
|
LGTM, left some nit-picks but they shouldn't block this. |
|
Thanks @stefanpenner! I'll poke at Stew's |
chancancode
added a commit
that referenced
this pull request
Jan 25, 2016
Make consumable from Ember without `npm link`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these changes a few things were missing from a build when just
npm install'ed (benchmarknode library, all of bower components libs, etc).This PR changes things around so that if devDeps or bower components are missing the main package libs still build properly.