This repository was archived by the owner on Jan 6, 2026. It is now read-only.
Fix source slicing for whitespace-stripping comments#1717
Merged
NullVoxPopuli merged 1 commit intomainfrom Feb 24, 2025
Merged
Conversation
Contributor
|
Re-apply #1430 with a more robust implementation and tests Also turns the warning into a `localAssert()` so it gets stripped before reaching downstream consumers. This relates to #1431 in that this removes the warning, so to the extent that #1431 was motivated by sliencing the warning in Ember builds, it avoids the issue. But I haven't investigated the root cause of that issue and whether it is indicative of an actual bug somewhere deeper. Fixes emberjs/ember.js#19392 Co-authored-by: Lee Nave <lee.nave@ovation.io>
1283e03 to
5256314
Compare
Contributor
|
Same as on main, so we're good here 🎉 thanks for fixing this! |
NullVoxPopuli
approved these changes
Feb 24, 2025
Merged
Contributor
|
Thanks!!! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Re-apply #1430 with a more robust implementation and tests
Also turns the warning into a
localAssert()so it gets stripped before reaching downstream consumers.This relates to #1431 in that this removes the warning, so to the extent that #1431 was motivated by sliencing the warning in Ember builds, it avoids the issue. But I haven't investigated the root cause of that issue and whether it is indicative of an actual bug somewhere deeper.
Fixes emberjs/ember.js#19392