This repository was archived by the owner on Jan 6, 2026. It is now read-only.
Conversation
Contributor
|
11 tasks
0c3159a to
5edcc29
Compare
| return this.#value; | ||
| } | ||
|
|
||
| set(value: Value): boolean { |
Contributor
There was a problem hiding this comment.
Would it be worth making the set a bounded func? For example:
set = (value: Value) => boolean {This way we could pass this into templates and not need to create a func just to set the value of a cell.
Contributor
Author
There was a problem hiding this comment.
how do you mean?
it's a bug in the vm that this doesn't work:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: emberjs/rfcs#1071
I want to RFC Resources, but we don't really have an implemented way to have reactivity in them right now.
We have:
trackedDatain@glimmer/validator-- this whole package should not be used by ember users tho, and most of its exports are not-RFC'd and should be considered private API@glimmer/tracking/primitives/storage-- this would work as an implementation of "Cell", but isn't implemented yet@tracked- requires creating class state, which many would feel is too cumbersome / verbose when for the "simple" cases, like having one valueTho, now that I've implemented this, I wonder if it can be placed in
@glimmer/tracking, since@glimmer/validatorexports so much.