Fix issues with "loose free variable" lookup by dropping unneeded GetFreeAsFallback op code
#1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetFreeAsFallback got broken by 179a388 As far as I can tell, it's never correct to call `withPath` by itself, it's always supposed to come after an opcode that leaves a value on the stack that needs path support. Rather than fix it, I'm going to try to cut the rest of it out, since it exists only to support `this` fallback.
snewcomer
approved these changes
Nov 5, 2021
| symbols, | ||
| head.path.tail | ||
| ); | ||
| return buildVar(head.path.head, VariableResolutionContext.Strict, symbols, head.path.tail); |
rwjblue
changed the title
GetFreeAsFallback op code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetFreeAsFallbackopcode got broken by 179a388. As far as I can tell, it's never correct to callwithPathby itself, it's always supposed to come after an opcode that leaves a value on the stack that needs path support.Rather than fix it, I'm going to try to cut the rest of it out, since it exists only to support
thisfallback.This still needs to get tested against Ember. I am unable to get Ember and glimmer-vm working correctly together locally, with or without these changes.