Avoid using a nested WeakMap for manager instances for a given owner. #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
approved these changes
Oct 13, 2021
The first level WeakMap is sufficient to prevent memory leaks. The only potential value that the second level WeakMap provides is to allow us to _unload_ code during the lifetime of a single owner instance, which is really not something that we support. Having nested WeakMap's breaks some tooling around memory leak investigation that we commonly use.
rwjblue
force-pushed
the
avoid-nested-weakmap
branch
from
de64c8c
to
30d57fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first level WeakMap is sufficient to prevent memory leaks. The only potential value that the second level WeakMap provides is to allow us to unload code during the lifetime of a single owner instance, which is really not something that we support.
Having nested WeakMap's breaks some tooling around memory leak investigation that we commonly use.