Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated versions of modifier/component manager capabilities from error messages #1343

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Sep 29, 2021

Error messages were incorrect, plus they're causing tests in ember.js to fail that check the error messages

@nlfurniss nlfurniss changed the title Remove deprecated version of modifier manager capabilities from error message Remove deprecated versions of modifier/component manager capabilities from error messages Sep 29, 2021
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rwjblue rwjblue added the bug label Sep 29, 2021
@rwjblue rwjblue merged commit 08c0356 into glimmerjs:master Sep 29, 2021
@nlfurniss nlfurniss deleted the patch-1 branch September 29, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants