-
Notifications
You must be signed in to change notification settings - Fork 190
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert changing helpers to return
Reference
s
Helpers are required to return `PathReference`s`, because their return values can be later used in lookup positions, e.g. ``` {{#with (my-helper) as |foo|}} {{foo.bar}} <--- referenceFromMyHelper.get('bar') {{/with}} ``` See emberjs/ember.js#13173 (comment) for more details. We were previously using `Function.prototype.call` to invoke helpers, which is typed to be `call(thisArg: any, args: any[]): any` which caused us to not get a TypeError from the change (because the return value is `any`). This commit fixed that as well.
- Loading branch information
Godhuda
committed
Apr 20, 2016
1 parent
6dfc32a
commit 8001311
Showing
4 changed files
with
18 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters