Skip to content

feat: Add icon to the IconButton's tooltip #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 12, 2022
Merged

feat: Add icon to the IconButton's tooltip #239

merged 10 commits into from
Jul 12, 2022

Conversation

@SilviaZeta
Copy link
Contributor

@SilviaZeta SilviaZeta commented Jun 23, 2022 •
edited
Loading

Description

  • add an icon at the end of the IconButton's tooltip and update the example page.
  • unset maxWidth for the Material-UI Dialog component used in Dialog.
  • add prop backgroundColor to Card and Dialog for setting a custom background colour.

relates to gliff-ai/roadmap#82

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@joshuajames-smith joshuajames-smith added the feature [Improvement] New feature request. label Jun 23, 2022
joshuajames-smith
joshuajames-smith suggested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@joshuajames-smith joshuajames-smith left a comment •
edited by SilviaZeta
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current Design:

Screenshot 2022-06-23 at 16 51 50 Screenshot 2022-06-23 at 16 52 05

Intended Design:

Screenshot 2022-06-23 at 16 57 16

  • The height of the tooltip w/ status is much larger than the tooltip w/ shortcut. This will be the padding. The height of these 2 components height should be the same.

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

joshuajames-smith
joshuajames-smith suggested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@joshuajames-smith joshuajames-smith left a comment •
edited by SilviaZeta
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could we change the CSS of the beta/alpha icon to height:24px;?
  • Tooltip text should also always be on one line - see below.

Screenshot 2022-06-24 at 10 59 57

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@joshuajames-smith joshuajames-smith self-requested a review June 24, 2022 10:43
joshuajames-smith
joshuajames-smith suggested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@joshuajames-smith joshuajames-smith left a comment •
edited by SilviaZeta
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Not sure what has happened but the circle keyboard shortcuts have been stretched? Can we fix this?

Screenshot 2022-06-24 at 11 43 48

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@joshuajames-smith joshuajames-smith self-requested a review June 24, 2022 13:31
@SilviaZeta SilviaZeta marked this pull request as draft June 27, 2022 09:40
@github-actions
Copy link

github-actions bot commented Jun 27, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 27, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 29, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 29, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@SilviaZeta SilviaZeta marked this pull request as ready for review July 12, 2022 14:27
@github-actions
Copy link

github-actions bot commented Jul 12, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-moss-0cf388303-239.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-island-0a3514503-239.westeurope.azurestaticapps.net

@SilviaZeta SilviaZeta merged commit cf20598 into main Jul 12, 2022
@SilviaZeta SilviaZeta deleted the tooltipWithIcon branch July 12, 2022 16:55
@SilviaZeta SilviaZeta mentioned this pull request Jul 18, 2022
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ChrisBaidoo ChrisBaidoo ChrisBaidoo approved these changes

@joshuajames-smith joshuajames-smith joshuajames-smith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature [Improvement] New feature request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SilviaZeta @ChrisBaidoo @joshuajames-smith