Skip to content

Conversation

@SilviaZeta
Copy link
Contributor

@SilviaZeta SilviaZeta commented Jun 29, 2022

Description

  • add the new fields description, is_public and origin to the Plugin model (and migrations!); origin is a ForeignKey that is set to None for origin plugins and it is a link to the origin plugin for copies of a plugin.
  • add the new fields public_key and encrypted_access_key to the TrustedService model; for these fields None values are allowed to facilitate the migration from the old to the new system, due to the fact that values for these fields must be generated by DOMINATE.
  • refactor plugins, so as to resolve the redundancy in plugin.py and trusted_service.py.

relates to gliff-ai/roadmap#82

DO NOT MERGE!

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@SilviaZeta SilviaZeta requested review from a team, ChasNelson1990 and philipjackson and removed request for a team June 29, 2022 16:20
@gliff-ai-robot gliff-ai-robot added the feature [Improvement] New feature request. label Jun 29, 2022
@SilviaZeta SilviaZeta changed the title feat: Add description and author to Plugin model feat: Add Zoo Jul 18, 2022
@SilviaZeta SilviaZeta self-assigned this Jul 18, 2022
ChasNelson1990
ChasNelson1990 previously approved these changes Jul 21, 2022
@SilviaZeta SilviaZeta marked this pull request as ready for review July 29, 2022 11:22
@SilviaZeta SilviaZeta changed the title feat: Add Zoo feat: Add Zoo (DO NOT MERGE) Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature [Improvement] New feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants