Vendor build directory to fix builds #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
force-pushed
the
fix-builds
branch
2 times, most recently
from
405d646 to
d172538
Compare
The upstream heroku/base-images switched to using a RUN mount and removed the inlining of certain files, causing build failures for gliderlabs/herokuish when executing their install scripts. To fix this, we _also_ vendor those files. Additionally, update the removal of postgresql from 15 to 16 to fix issues with building on arm.
josegonzalez
force-pushed
the
fix-builds
branch
from
d172538 to
324c2cb
Compare
josegonzalez
added a commit
that referenced
this pull request
Mar 28, 2024
- #1148 @dokku-bot: Update go to version v189 - #1149 @dokku-bot: Update nodejs to version v238 - #1152 @dependabot: chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.12.1 to 3.13.0 in /buildpacks/buildpack-java/tests/java-jetty - #1153 @dependabot: chore(deps): bump rack from 2.2.8.1 to 2.2.9 in /buildpacks/buildpack-ruby/tests/ruby-sinatra - #1154 @dependabot: chore(deps): bump rack from 3.0.9.1 to 3.0.10 in /buildpacks/buildpack-multi/tests/multi - #1159 @josegonzalez: chore: update ruby in ci to latest version to fix releases - #1160 @josegonzalez: Vendor build directory to fix builds - #1161 @dependabot: chore(deps): bump express from 4.18.3 to 4.19.2 in /buildpacks/buildpack-nodejs/tests/nodejs-express - #1162 @dependabot: chore(deps): bump express from 4.18.3 to 4.19.2 in /buildpacks/buildpack-multi/tests/multi - #1167 @dokku-bot: Update nodejs to version v239 - #1168 @dokku-bot: Update python to version v246 - #1169 @dokku-bot: Update nodejs to version v240
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream heroku/base-images switched to using a RUN mount and removed the inlining of certain files, causing build failures for gliderlabs/herokuish when executing their install scripts. To fix this, we also vendor those files.
Additionally, update the removal of postgresql-client from 15 to 16 to fix issues with building on arm.