Skip to content

Improve the error message when echo tests fail on missing target executable#4315

Merged
lpil merged 1 commit intogleam-lang:mainfrom
sbergen:ImproveEchoTestFailureMessage
Mar 10, 2025
Merged

Improve the error message when echo tests fail on missing target executable#4315
lpil merged 1 commit intogleam-lang:mainfrom
sbergen:ImproveEchoTestFailureMessage

Conversation

@sbergen
Copy link
Copy Markdown
Contributor

@sbergen sbergen commented Mar 9, 2025

If you don't have an executable required by the echo tests installed, you'd get a somewhat cryptic error along the lines of:

thread 'tests::echo::echo_dict' panicked at test-output/src/tests/echo.rs:74:10:
spawn run process: Os { code: 2, kind: NotFound, message: "No such file or directory" }

It will now be this instead (if you don't have bun installed):

thread 'tests::echo::echo_dict' panicked at test-output/src/tests/echo.rs:74:29:
Failed to spawn process 'bun': No such file or directory (os error 2)

Copy link
Copy Markdown
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit 2bbe1dc into gleam-lang:main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants