Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-268: add more tests for glass.core #263

Merged
merged 6 commits into from
Oct 1, 2024
Merged

gh-268: add more tests for glass.core #263

merged 6 commits into from
Oct 1, 2024
+103 −0

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Sep 24, 2024 •
edited by paddyroddy
Loading

Add missing tests for glass.core.array.broadcast_first and glass.core.array.test_cumtrapz. Improve coverage for glass.core.algorithms.nnls.

Closes #268

@Saransh-cpp Saransh-cpp added the maintenance Maintenance: refactoring, typos, etc. label Sep 24, 2024
paddyroddy
paddyroddy requested changes Sep 25, 2024
View reviewed changes
glass/core/algorithm.py Outdated Show resolved Hide resolved
tests/core/test_algorithm.py Outdated Show resolved Hide resolved
tests/core/test_array.py Show resolved Hide resolved
tests/core/test_array.py Outdated Show resolved Hide resolved
tests/core/test_array.py Show resolved Hide resolved
@paddyroddy paddyroddy mentioned this pull request Sep 25, 2024
Open
@paddyroddy paddyroddy changed the title gh-161: cleanup and add more tests for glass.core gh-268: cleanup and add more tests for glass.core Sep 25, 2024
@Saransh-cpp Saransh-cpp marked this pull request as draft September 25, 2024 15:08
@Saransh-cpp Saransh-cpp mentioned this pull request Sep 26, 2024
Open
@Saransh-cpp
Copy link
Member Author

Need to add some comments and docstring.

@Saransh-cpp Saransh-cpp changed the title gh-268: cleanup and add more tests for glass.core gh-268: add more tests for glass.core Sep 27, 2024
@Saransh-cpp Saransh-cpp marked this pull request as ready for review September 27, 2024 11:14
paddyroddy
paddyroddy approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Saransh-cpp Saransh-cpp self-assigned this Sep 27, 2024
@paddyroddy
Copy link
Member

Merging

@paddyroddy paddyroddy merged commit 6f89444 into main Oct 1, 2024
10 checks passed
@paddyroddy paddyroddy deleted the saransh/core-tests branch October 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddyroddy paddyroddy paddyroddy approved these changes

@ntessore ntessore Awaiting requested review from ntessore

Assignees

@Saransh-cpp Saransh-cpp

Labels
maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/review tests for glass.core
3 participants
@Saransh-cpp @paddyroddy @ntessore