Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply actionlint #302

Closed
paddyroddy opened this issue Oct 2, 2024 · 1 comment
Closed

Apply actionlint #302

paddyroddy opened this issue Oct 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@paddyroddy
Copy link
Member

Is Your Feature Request Related to a Problem? Please Describe

Add https://github.com/rhysd/actionlint to lint the GitHub Action workflows

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response

@paddyroddy paddyroddy added the enhancement New feature or request label Oct 2, 2024
@paddyroddy paddyroddy self-assigned this Oct 2, 2024
paddyroddy added a commit that referenced this issue Oct 2, 2024
paddyroddy added a commit that referenced this issue Oct 3, 2024
Add https://github.com/rhysd/actionlint to check through GitHub Actions
workflows.

The fix was related to this error

```yaml
.github/workflows/test.yml:51:31: receiver of object dereference "key" must be type of object but got "number" [expression]
   |
51 |           nox -s doctests-${{ matrix.python-version.key || matrix.python-version
   |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/test.yml:55:31: receiver of object dereference "key" must be type of object but got "number" [expression]
   |
55 |           nox -s coverage-${{ matrix.python-version.key || matrix.python-version
```

Why did we have this `matrix.python-version.key` bit @Saransh-cpp?
Introduced in #287, sorry I
missed it.
@paddyroddy
Copy link
Member Author

Closed in #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant