Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where possible add config options to pyproject.toml rather than .pre-commit-config.yaml #267

Closed
paddyroddy opened this issue Sep 25, 2024 · 1 comment · Fixed by #284
Closed

Where possible add config options to pyproject.toml rather than .pre-commit-config.yaml #267

paddyroddy opened this issue Sep 25, 2024 · 1 comment · Fixed by #284
Assignees
@paddyroddy
Labels
enhancement New feature or request

Comments

@paddyroddy
Copy link
Member

Is Your Feature Request Related to a Problem? Please Describe

The main advantage of this is that it means whenever one runs, say, ruff it will apply the config. If it is only in the pre-commit then it will only apply when running ruff via pre-commit.

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@paddyroddy paddyroddy added the enhancement New feature or request label Sep 25, 2024
@paddyroddy paddyroddy self-assigned this Sep 25, 2024
@paddyroddy paddyroddy mentioned this issue Sep 25, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 25, 2024
@Saransh-cpp
gh-267: move verbose output flag for ruff and pytest to pyproject.toml
b4e56b5
@Saransh-cpp Saransh-cpp mentioned this issue Sep 25, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 25, 2024
@Saransh-cpp
gh-267: move verbose output flag for ruff and pytest to pyproject.toml
a212411
@paddyroddy paddyroddy mentioned this issue Sep 25, 2024
Merged
@paddyroddy
Copy link
Member Author

#232 (comment)

paddyroddy pushed a commit that referenced this issue Sep 25, 2024
@Saransh-cpp
gh-267: move verbose output flag for ruff and pytest to pyproject.toml (
f821e64 
#281)

Verbose output flags for both ruff and pytest are used frequently enough
to be added to pyproject.toml.

Refs: #267
Saransh-cpp added a commit that referenced this issue Sep 25, 2024
@Saransh-cpp
gh-267: move verbose output flag for ruff and pytest to pyproject.toml (
7ed191d 
#281)

Verbose output flags for both ruff and pytest are used frequently enough
to be added to pyproject.toml.

Refs: #267
@paddyroddy paddyroddy mentioned this issue Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-267: move arguments from pre-commit to config files glass-dev/glass
1 participant
@paddyroddy