Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recache page after mutation #127

Merged
merged 3 commits into from
Mar 17, 2021
Merged

recache page after mutation #127

merged 3 commits into from
Mar 17, 2021

Conversation

amaliwanag2
Copy link
Contributor

@kmjennison I think we still want a stale while revalidating strategy to cache assets besidies the /newtab page but I left a comment in the workbox config with more details

@vercel
Copy link

vercel bot commented Mar 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gladly-team/tab-web/9aqahQiKGtaTjSq65Z7kYpeJ2mES
✅ Preview: https://tab-web-git-alec-tfac-244-gladly-team.vercel.app

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #127 (cde2894) into master (78ac97e) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   89.09%   89.27%   +0.17%     
==========================================
  Files          80       81       +1     
  Lines        1119     1193      +74     
  Branches      267      297      +30     
==========================================
+ Hits          997     1065      +68     
- Misses        109      115       +6     
  Partials       13       13              
Impacted Files Coverage Δ
src/components/UserImpact.js 97.36% <ø> (-0.20%) ⬇️
src/utils/mutations/LogUserRevenueMutation.js 100.00% <ø> (ø)
src/pages/index.js 88.79% <100.00%> (-0.25%) ⬇️
src/utils/caching.js 20.00% <100.00%> (ø)
src/utils/mutations/callMutation.js 100.00% <100.00%> (ø)
src/components/ImpactDialog.js 92.68% <0.00%> (-1.07%) ⬇️
src/components/MoneyRaised.js 100.00% <0.00%> (ø)
src/components/DashboardPopover.js 100.00% <0.00%> (ø)
src/utils/urls.js 93.75% <0.00%> (+0.20%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ac97e...cde2894. Read the comment docs.

Copy link
Contributor

@kmjennison kmjennison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

.eslintrc.js Outdated Show resolved Hide resolved
src/utils/mutations/callMutation.js Outdated Show resolved Hide resolved
next.config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@kmjennison kmjennison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍝

@kmjennison kmjennison merged commit aa47e1c into master Mar 17, 2021
@kmjennison kmjennison deleted the alec/TFAC-244 branch March 17, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants