-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recache page after mutation #127
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/gladly-team/tab-web/9aqahQiKGtaTjSq65Z7kYpeJ2mES |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 89.09% 89.27% +0.17%
==========================================
Files 80 81 +1
Lines 1119 1193 +74
Branches 267 297 +30
==========================================
+ Hits 997 1065 +68
- Misses 109 115 +6
Partials 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍝
@kmjennison I think we still want a stale while revalidating strategy to cache assets besidies the /newtab page but I left a comment in the workbox config with more details