-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace outdated react-firebaseui package #694
Conversation
@MvRemmerden is attempting to deploy a commit to the Gladly Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! It looks great. Just requesting a few quick edits.
Done, back to you 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just requesting another minor lint fix. Reminder that you can check linting yourself locally by running yarn lint
at the package root. Thanks for these edits!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.x #694 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 31 31
Lines 888 888
Branches 270 270
=======================================
Hits 871 871
Misses 17 17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you for the contribution and revisions!
No worries, thanks for the guidance! Very happy to have contributed at least something back to this project, which has been super helpful for me! 🙂 |
This replaces the outdated
react-firebaseui
package as mentioned in #555.