Skip to content

DOM release currently reported as one day early #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csuhta opened this issue Apr 24, 2018 · 3 comments
Closed

DOM release currently reported as one day early #75

csuhta opened this issue Apr 24, 2018 · 3 comments

Comments

@csuhta
Copy link

csuhta commented Apr 24, 2018

9smrgbquzj
@Nightfirecat
Copy link
Contributor

I'm not seeing that behavior.

untitled

Furthermore, the code is correct: https://github.com/glacials/whatsinstandard/blob/master/api/v5/sets.json#L104

Possibly a Javascript timezone/clock issue?

@csuhta
Copy link
Author

csuhta commented Apr 24, 2018 •
edited
Loading

If the code is localizing 2018-04-27T00:00:00.000Z into the current browser's timezone, that will result in some some people seeing the day before or after the 27th, which is not correct.

Dominaria releases at midnight on April 27 in each time zone, not at exactly the time 2018-04-27 00:00 UTC

These dates should be interpreted a "calendar dates" without a time zone, not as full localizable timestamps

glacials added a commit that referenced this issue Apr 28, 2018
@glacials
Don't include timezone in API dates
145c7e3 
Explicitly leave off timezone in all ISO 8601 dates. Set release dates
are always in midnight local time, not midnight UTC or any other
specific timezone, so these should be parse with the local timezone. In
ISO 8601, the absence of a timezone means the parser should use local
time. Fixes #75.
@glacials
Copy link
Owner

Thanks yall, should be fixed!

@glacials glacials mentioned this issue Feb 19, 2023
Closed
glacials added a commit that referenced this issue Feb 20, 2023
@glacials
Fix date.exact promise from RFC 3339 to ISO 8601
152fecb 
We have not satisfied RFC 3339 since we removed timestmaps in response
to #75. See also #255.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glacials @csuhta @Nightfirecat