Handle various orders of input data #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t grid directions
- make clear what this. refers to - revisit sampleMeshgrid arguments
- uninstall devdep gl-mesh3d - install dep glsl-specular-cook-torrance
|
@etpinard thanks for review and the confirmation to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gl-streamtube3dmodule used to make assumptions about the order of input data which could be false in cases where the data cube was not filled in orders thanxyz(i.e firstx| nexty| lastz).This PR addresses this issue by considering the order of data.
Please refer to plotly/plotly.js#4271 for more info.
I addition this PR refactors parts of the code
@etpinard