Fix4924 discrete heatmap2d #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' into discrete-heatmap2d # Conflicts: # package-lock.json
archmoj
reviewed
Jul 7, 2020
.gitignore
Outdated
| *.DS_Store | ||
| gh-pages | ||
| .Rproj.user | ||
| gl-heatmap2d.Rproj |
|
@ordiology thanks very much for the PR. |
… removed unnecessary additions to the .gitignore.
archmoj
reviewed
Jul 8, 2020
|
|
||
| npm-debug.log | ||
| node_modules/* | ||
| package-lock.json |
There was a problem hiding this comment.
Let's revert these changes in .gitignore file.
There was a problem hiding this comment.
I've tried to do this, but I'm not sure I've done it correctly. Please let me know if there's still an issue.
archmoj
reviewed
Jul 8, 2020
|
@ordiology thanks very much for th PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of gl-heatmap2d modifies Mikola Lysenko's original code to optionally produced a discretised heatmap instead of an interpolated one. This is achieved by introducing an is.smooth variable:
var isSmooth = options.zsmooth !== false
Scientific data is often discretised and this option will allow the data to be represented as measured rather than smoothing between observations.
This change will resolve this plotly issue: plotly/plotly.js#4924, and is currently being addressed in this pull: plotly/plotly.js#4953