Skip to content

Tick diffing to check all properties that impact the rendered result #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Tick diffing to check all properties that impact the rendered result #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/ticks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,15 @@ function ticksEqual(ticksA, ticksB) {
for(var j=0; j<ticksA[i].length; ++j) {
var a = ticksA[i][j]
var b = ticksB[i][j]
if(a.x !== b.x || a.text !== b.text) {
if(
a.x !== b.x ||
a.text !== b.text ||
a.font !== b.font ||
a.fontColor !== b.fontColor ||
a.fontSize !== b.fontSize ||
a.dx !== b.dx ||
a.dy !== b.dy
Copy link
Member

@etpinard etpinard Sep 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely fix.

Copy link
Member Author

@monfera monfera Sep 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit repetitive but it's in a potentially perf critical code part - e.g. now runs on each hover move - and there may be internal properties too so I ended up not JSON.stringifying it or adding a loop on Object.keys

) {
return false
}
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gl-axes3d",
"version": "1.2.4",
"version": "1.2.5",
"description": "3D axes for WebGL",
"main": "axes.js",
"directories": {
Expand Down