Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildtree updates #632

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Buildtree updates #632

merged 2 commits into from
Jan 29, 2024

Conversation

gkjohnson
Copy link
Owner

General changes from #627

@gkjohnson gkjohnson marked this pull request as ready for review January 29, 2024 09:04
@gkjohnson
Copy link
Owner Author

This PR should only affect build times so I expect these increases are in the noise.

BVH Casts

before after delta increase
IntersectsBox
*  mean 0.00721 ms 0.00755 ms 0.00034 ms 4.72639 %

Indirect BVH Casts

before after delta increase
IntersectsBox
*  mean 0.00211 ms 0.00259 ms 0.00048 ms 22.63714 %

Indirect BVH Misc

before after delta increase
Compute Bounds
*  mean 0.00019 ms 0.00021 ms 0.00001 ms 7.48560 %

Tower Case Geometry

before after delta increase
CENTER raycast
*  mean 0.00578 ms 0.00604 ms 0.00026 ms 4.44693 %
*  median 0.00467 ms 0.00517 ms 0.00050 ms 10.68655 %
Full Benchmark

BVH General

before after delta increase
Serialize
   mean 0.90783 ms 0.84846 ms -0.05937 ms -6.53929 %
   median 0.88202 ms 0.83277 ms -0.04925 ms -5.58375 %
Desrialize
   mean 0.11103 ms 0.11333 ms 0.00230 ms 2.07387 %
   median 0.11223 ms 0.11112 ms -0.00110 ms -0.98423 %

BVH Casts

before after delta increase
Compute BVH
   mean 147.41471 ms 145.41219 ms -2.00252 ms -1.35843 %
   median 148.99648 ms 145.33473 ms -3.66175 ms -2.45761 %
Compute BVH w/ groups
   mean 155.59401 ms 138.93144 ms -16.66256 ms -10.70900 %
   median 155.14738 ms 138.72004 ms -16.42733 ms -10.58821 %
Raycast
   mean 0.09444 ms 0.07287 ms -0.02157 ms -22.84127 %
   median 0.08904 ms 0.06838 ms -0.02067 ms -23.21002 %
Raycast Shapecast
   mean 0.10669 ms 0.10907 ms 0.00237 ms 2.22301 %
   median 0.10179 ms 0.10400 ms 0.00221 ms 2.16888 %
Raycast First Hit
   mean 0.00635 ms 0.00600 ms -0.00035 ms -5.52607 %
   median 0.00662 ms 0.00621 ms -0.00042 ms -6.28374 %
Raycast First Hit Shapecast
   mean 0.00715 ms 0.00705 ms -0.00010 ms -1.45656 %
   median 0.00733 ms 0.00733 ms -0.00000 ms -0.00650 %
Sphere Shapecast
   mean 0.00239 ms 0.00242 ms 0.00003 ms 1.30965 %
   median 0.00242 ms 0.00242 ms 0.00000 ms 0.00000 %
IntersectsSphere
   mean 0.00237 ms 0.00231 ms -0.00005 ms -2.23801 %
   median 0.00246 ms 0.00246 ms 0.00000 ms 0.00000 %
IntersectsBox
*  mean 0.00721 ms 0.00755 ms 0.00034 ms 4.72639 %
   median 0.00373 ms 0.00313 ms -0.00060 ms -16.19462 %
DistanceToGeometry w/ BVH
   mean 108.68269 ms 108.54876 ms -0.13393 ms -0.12323 %
   median 108.69250 ms 108.57892 ms -0.11358 ms -0.10450 %
DistanceToPoint
   mean 0.09719 ms 0.09799 ms 0.00081 ms 0.82872 %
   median 0.09542 ms 0.09554 ms 0.00012 ms 0.13093 %
IntersectsGeometry w/ BVH
   mean 2.81776 ms 2.83148 ms 0.01372 ms 0.48699 %
   median 2.80281 ms 2.81473 ms 0.01192 ms 0.42518 %
IntersectsGeometry w/o BVH
   mean 43.21257 ms 43.74581 ms 0.53324 ms 1.23399 %
   median 43.19927 ms 43.77733 ms 0.57806 ms 1.33813 %
BVHCast
   mean 69.66019 ms 70.82152 ms 1.16133 ms 1.66713 %
   median 69.49496 ms 70.66965 ms 1.17469 ms 1.69032 %

BVH Misc

before after delta increase
Refit
   mean 97.61257 ms 14.91267 ms -82.69991 ms -84.72260 %
   median 14.92904 ms 14.89573 ms -0.03331 ms -0.22314 %
Refit with Hints
   mean 0.58423 ms 0.50285 ms -0.08139 ms -13.93048 %
   median 0.52623 ms 0.50271 ms -0.02352 ms -4.46972 %
Compute Bounds
   mean 0.00025 ms 0.00023 ms -0.00003 ms -10.45931 %
   median 0.00021 ms 0.00021 ms 0.00000 ms 0.00000 %
Compute Bounds w/o
   mean 1.36687 ms 1.34706 ms -0.01981 ms -1.44897 %
   median 1.36079 ms 1.34762 ms -0.01317 ms -0.96763 %

Indirect BVH Casts

before after delta increase
Compute BVH
   mean 139.46862 ms 136.43469 ms -3.03393 ms -2.17535 %
   median 140.34879 ms 136.34862 ms -4.00017 ms -2.85016 %
Compute BVH w/ groups
   mean 162.76805 ms 155.68016 ms -7.08790 ms -4.35460 %
   median 162.94246 ms 155.52463 ms -7.41783 ms -4.55243 %
Raycast
   mean 0.09896 ms 0.07949 ms -0.01947 ms -19.67898 %
   median 0.09729 ms 0.07746 ms -0.01983 ms -20.38611 %
Raycast Shapecast
   mean 0.10366 ms 0.10461 ms 0.00094 ms 0.91158 %
   median 0.09979 ms 0.10029 ms 0.00050 ms 0.50077 %
Raycast First Hit
   mean 0.00531 ms 0.00499 ms -0.00032 ms -5.98534 %
   median 0.00563 ms 0.00508 ms -0.00054 ms -9.62109 %
Raycast First Hit Shapecast
   mean 0.00447 ms 0.00450 ms 0.00004 ms 0.81820 %
   median 0.00413 ms 0.00421 ms 0.00008 ms 2.01133 %
Sphere Shapecast
   mean 0.00192 ms 0.00190 ms -0.00002 ms -1.20809 %
   median 0.00208 ms 0.00208 ms 0.00000 ms 0.00000 %
IntersectsSphere
   mean 0.00166 ms 0.00163 ms -0.00002 ms -1.33358 %
   median 0.00146 ms 0.00146 ms 0.00000 ms 0.00000 %
IntersectsBox
*  mean 0.00211 ms 0.00259 ms 0.00048 ms 22.63714 %
   median 0.00204 ms 0.00208 ms 0.00004 ms 2.00841 %
DistanceToGeometry w/ BVH
   mean 108.66153 ms 108.48272 ms -0.17881 ms -0.16456 %
   median 108.68687 ms 108.47054 ms -0.21633 ms -0.19904 %
DistanceToPoint
   mean 0.10469 ms 0.10350 ms -0.00119 ms -1.13623 %
   median 0.10204 ms 0.10213 ms 0.00008 ms 0.08131 %
IntersectsGeometry w/ BVH
   mean 2.95090 ms 2.97659 ms 0.02569 ms 0.87070 %
   median 2.93296 ms 2.95925 ms 0.02629 ms 0.89641 %
IntersectsGeometry w/o BVH
   mean 44.55372 ms 44.48846 ms -0.06526 ms -0.14647 %
   median 44.49433 ms 44.49115 ms -0.00319 ms -0.00716 %
BVHCast
   mean 70.37222 ms 71.38754 ms 1.01531 ms 1.44278 %
   median 70.25004 ms 71.23696 ms 0.98692 ms 1.40486 %

Indirect BVH Misc

before after delta increase
Refit
   mean 16.86945 ms 16.94756 ms 0.07811 ms 0.46305 %
   median 16.83971 ms 16.90671 ms 0.06700 ms 0.39787 %
Refit with Hints
   mean 0.57637 ms 0.57853 ms 0.00216 ms 0.37464 %
   median 0.57525 ms 0.57788 ms 0.00262 ms 0.45632 %
Compute Bounds
*  mean 0.00019 ms 0.00021 ms 0.00001 ms 7.48560 %
   median 0.00017 ms 0.00017 ms 0.00000 ms 0.00000 %
Compute Bounds w/o
   mean 1.33886 ms 1.35768 ms 0.01882 ms 1.40594 %
   median 1.33300 ms 1.35637 ms 0.02337 ms 1.75353 %

Math Functions

before after delta increase
IntersectTri w/o Target
   mean 0.00032 ms 0.00032 ms 0.00001 ms 1.78386 %
   median 0.00033 ms 0.00033 ms 0.00000 ms 0.00000 %
IntersectTri w/ Target
   mean 0.00063 ms 0.00064 ms 0.00001 ms 1.66822 %
   median 0.00058 ms 0.00058 ms 0.00000 ms 0.00000 %
IntersectTri w/ Update
   mean 0.00073 ms 0.00074 ms 0.00001 ms 1.09204 %
   median 0.00075 ms 0.00075 ms 0.00000 ms 0.06361 %

Tower Case Geometry

before after delta increase
CENTER raycast
*  mean 0.00578 ms 0.00604 ms 0.00026 ms 4.44693 %
*  median 0.00467 ms 0.00517 ms 0.00050 ms 10.68655 %
AVERAGE raycast
   mean 0.00233 ms 0.00213 ms -0.00019 ms -8.26908 %
   median 0.00229 ms 0.00200 ms -0.00029 ms -12.73143 %
SAH raycast
   mean 0.00888 ms 0.00670 ms -0.00217 ms -24.47300 %
   median 0.00650 ms 0.00558 ms -0.00092 ms -14.10755 %

@gkjohnson gkjohnson merged commit 082b3de into master Jan 29, 2024
4 checks passed
@gkjohnson gkjohnson deleted the buildtree-updates branch January 29, 2024 09:08
@gkjohnson gkjohnson mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gkjohnson